Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 )
Change subject: IMPALA-8852: Skip short-circuit config check for coordinator-only mode ...................................................................... Patch Set 4: (1 comment) Thank you for the review again. Fixed the code style nit. http://gerrit.cloudera.org:8080/#/c/15173/3/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java File fe/src/test/java/org/apache/impala/service/JniFrontendTest.java: http://gerrit.cloudera.org:8080/#/c/15173/3/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@79 PS3, Line 79: + " > Line 79 and 80 should have 4 space indent. I know these can be difficult to Installed the google style, thank you. However, for some reason clang-format and with this style IntelliJ double idents when a parameter is split into multiple lines. I will keep an eye on the style around the change, also will try configure this option in IntelliJ. -- To view, visit http://gerrit.cloudera.org:8080/15173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I373d4037f4cee203322a398b77b75810ba708bb5 Gerrit-Change-Number: 15173 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Sat, 08 Feb 2020 10:59:19 +0000 Gerrit-HasComments: Yes
