Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15178 )
Change subject: IMPALA-9243: Add info about blacklisting decisions to the webui ...................................................................... Patch Set 2: Code-Review+1 (1 comment) This looks good to me. One question for my own understanding. If no one else wants to review, I will bump to +2. http://gerrit.cloudera.org:8080/#/c/15178/2/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/15178/2/be/src/service/impala-http-handler.cc@1001 PS2, Line 1001: if (num_quiescing_backends > 0) { : document->AddMember( : "num_quiescing_backends", num_quiescing_backends, document->GetAllocator()); : } : if (num_blacklisted_backends > 0) { : document->AddMember( : "num_blacklisted_backends", num_blacklisted_backends, document->GetAllocator()); : } For my own understanding, if num_quiescing_backends is zero and we don't add the member, what does this code in www/backends.tmpl do? {{#num_quiescing_backends}} ... content ... {{/num_quiescing_backends}} I assume this would skip the whole chunk. Is that right? The context is I'm wondering whether it matters that we don't add these members vs adding them with a count of zero. -- To view, visit http://gerrit.cloudera.org:8080/15178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0c309315b142a50be102dcb516b36ec6cb3cf47 Gerrit-Change-Number: 15178 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Fri, 07 Feb 2020 19:37:18 +0000 Gerrit-HasComments: Yes
