Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15178 )
Change subject: IMPALA-9243: Add info about blacklisting decisions to the webui ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15178/2/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/15178/2/be/src/service/impala-http-handler.cc@1001 PS2, Line 1001: // Don't add the following fields if they're 0 so that we won't display the : // corresponding tables if they would be empty. : if (num_quiescing_backends > 0) { : document->AddMember( : "num_quiescing_backends", num_quiescing_backends, document->GetAllocator()); : } : if (num_blacklisted_backends > 0) { : > For my own understanding, if num_quiescing_backends is zero and we don't ad Right, I figured it would be better not to clutter up the page with the extra empty tables in the common case where the cluster is healthy. Added a comment here explaining. -- To view, visit http://gerrit.cloudera.org:8080/15178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0c309315b142a50be102dcb516b36ec6cb3cf47 Gerrit-Change-Number: 15178 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Fri, 07 Feb 2020 23:24:15 +0000 Gerrit-HasComments: Yes
