Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15214 )
Change subject: IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre ...................................................................... Patch Set 1: Code-Review+1 (9 comments) http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2071 PS1, Line 2071: createUnstarted I would prefer to remove the static import as this is not as clear as Stopwatch.createUnstarted().start() would be. Stopwatch.createStarted() would be even better. http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/catalog/Table.java@414 PS1, Line 414: createUnstarted Same as in CatalogServiceCatalog.java http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/catalog/TableLoader.java File fe/src/main/java/org/apache/impala/catalog/TableLoader.java: http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/catalog/TableLoader.java@59 PS1, Line 59: createUnstarted Same as in CatalogServiceCatalog.java http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@110 PS1, Line 110: import static com.google.common.base.Stopwatch.createUnstarted; Same as in CatalogServiceCatalog.java http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@199 PS1, Line 199: import static com.google.common.base.Stopwatch.createUnstarted; Same as in CatalogServiceCatalog.java http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1752 PS1, Line 1752: ; double ; http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/util/JvmPauseMonitor.java File fe/src/main/java/org/apache/impala/util/JvmPauseMonitor.java: http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/util/JvmPauseMonitor.java@189 PS1, Line 189: createUnstarted I would prefer the longer Stopwatch.createUnstarted() http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/util/JvmPauseMonitor.java@190 PS1, Line 190: Stopwatch timeSinceDeadlockCheck = createUnstarted().start(); Same as in CatalogServiceCatalog.java http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java File fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java: http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java@290 PS1, Line 290: Stopwatch sw = createUnstarted().start(); Same as in CatalogServiceCatalog.java -- To view, visit http://gerrit.cloudera.org:8080/15214 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9690a926953a8d3c3872277680b4be0551546c68 Gerrit-Change-Number: 15214 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Thu, 13 Feb 2020 10:21:26 +0000 Gerrit-HasComments: Yes
