Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15214 )
Change subject: IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/15214/1/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@67 PS1, Line 67: import static java.util.concurrent.TimeUnit.MILLISECONDS; nit, I think parts of the code use TimeUnit.MILLISECONDS which is probably more clear. May be remove the static import? -- To view, visit http://gerrit.cloudera.org:8080/15214 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9690a926953a8d3c3872277680b4be0551546c68 Gerrit-Change-Number: 15214 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Thu, 13 Feb 2020 18:31:18 +0000 Gerrit-HasComments: Yes
