Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15222 )
Change subject: IMPALA-9385: Unix time conversion cleanup + ORC fix ...................................................................... Patch Set 11: Code-Review+1 (3 comments) Left some comments, otherwise it LGTM. Will you open a Jira for the postponed changes/TODOs? http://gerrit.cloudera.org:8080/#/c/15222/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15222/11//COMMIT_MSG@9 PS11, Line 9: Orc nit: ORC http://gerrit.cloudera.org:8080/#/c/15222/11/be/src/common/global-types.h File be/src/common/global-types.h: http://gerrit.cloudera.org:8080/#/c/15222/11/be/src/common/global-types.h@33 PS11, Line 33: UTCPTR Since it's not a macro anymore, maybe UtcPtr would be a better name? http://gerrit.cloudera.org:8080/#/c/15222/11/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: http://gerrit.cloudera.org:8080/#/c/15222/11/be/src/runtime/timestamp-value.h@a35 PS11, Line 35: : Shouldn't we keep this comment? -- To view, visit http://gerrit.cloudera.org:8080/15222 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14e2a7e512ccd013d5d9fe480a5467ed4c46b76e Gerrit-Change-Number: 15222 Gerrit-PatchSet: 11 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 20 Feb 2020 16:28:45 +0000 Gerrit-HasComments: Yes
