Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15222 )
Change subject: IMPALA-9385: Unix time conversion cleanup + ORC fix ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/15222/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15222/11//COMMIT_MSG@9 PS11, Line 9: Orc > nit: ORC Done http://gerrit.cloudera.org:8080/#/c/15222/11/be/src/common/global-types.h File be/src/common/global-types.h: http://gerrit.cloudera.org:8080/#/c/15222/11/be/src/common/global-types.h@33 PS11, Line 33: UTCPTR > Since it's not a macro anymore, maybe UtcPtr would be a better name? I prefer it all capital for some reason, not sure why :) We use all capital consts in Impala in several places. http://gerrit.cloudera.org:8080/#/c/15222/11/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: http://gerrit.cloudera.org:8080/#/c/15222/11/be/src/runtime/timestamp-value.h@a35 PS11, Line 35: : > Shouldn't we keep this comment? There is no agreement about this - turning it on by default could make some queries much slower. I think that this comment is just confusing. -- To view, visit http://gerrit.cloudera.org:8080/15222 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14e2a7e512ccd013d5d9fe480a5467ed4c46b76e Gerrit-Change-Number: 15222 Gerrit-PatchSet: 11 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 20 Feb 2020 19:31:49 +0000 Gerrit-HasComments: Yes
