Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 )
Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/15251/2/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/15251/2/be/src/util/runtime-profile.cc@1204 PS2, Line 1204: e* nit: It would be nice to use a reference to make the change less noisy. Maybe give the argument another name and create a "TRuntimeProfileNode& node" local variable if we want to keep the "arguments are not references" policy. http://gerrit.cloudera.org:8080/#/c/15251/2/be/src/util/runtime-profile.cc@1218 PS2, Line 1218: str Using a string* here could avoid the extra copies. http://gerrit.cloudera.org:8080/#/c/15251/2/be/src/util/runtime-profile.cc@1218 PS2, Line 1218: Counter Is it possible to make this const? It would make it clearer why it is ok the process this outside of counter_map_lock_ -- To view, visit http://gerrit.cloudera.org:8080/15251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f85ef005ae3b793515b223d4c04bbd898336065 Gerrit-Change-Number: 15251 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 20 Feb 2020 16:58:45 +0000 Gerrit-HasComments: Yes
