Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 )
Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() ...................................................................... Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15251/4/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/15251/4/be/src/util/runtime-profile.cc@1263 PS4, Line 1263: r (const SummaryStatsCounterMap > I guess that there are only a few events so this probably wouldn't matter m I think the typical length is 5-10 events, so optimising for long lists is not worthwhile. I think gcc's std::sort() is O(n) in practice for short sorted lists - it does an intro-sort that does insertion sort for < 16 elements. I did notice that I could avoid a string copy by moving the label into the output list. -- To view, visit http://gerrit.cloudera.org:8080/15251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f85ef005ae3b793515b223d4c04bbd898336065 Gerrit-Change-Number: 15251 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 20 Feb 2020 22:21:09 +0000 Gerrit-HasComments: Yes
