Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15244 )
Change subject: IMPALA-5904: (part 2) Fix more TSAN bugs ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15244/2/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/15244/2/be/src/runtime/krpc-data-stream-sender.cc@583 PS2, Line 583: #ifndef NDEBUG > I'd prefer to avoid changes to locking in debug builds - this could make it Added a suppression. Had to move the DCHECK into a dedicated method since suppressions require specifying a target method. http://gerrit.cloudera.org:8080/#/c/15244/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/15244/2/be/src/service/impala-server.cc@820 PS2, Line 820: query->fetch_rows_lock()->lock(); > Why not use a lock_guard? Done -- To view, visit http://gerrit.cloudera.org:8080/15244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01feb40417dc5ea64ccb0c1044cfc3eed8508476 Gerrit-Change-Number: 15244 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 21 Feb 2020 00:08:46 +0000 Gerrit-HasComments: Yes
