Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15244 )
Change subject: IMPALA-5904: (part 2) Fix more TSAN bugs ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/15244/4/be/src/exec/parquet/parquet-column-readers.h File be/src/exec/parquet/parquet-column-readers.h: http://gerrit.cloudera.org:8080/#/c/15244/4/be/src/exec/parquet/parquet-column-readers.h@23 PS4, Line 23: #include "exec/parquet/hdfs-parquet-scanner.h" We're using Atomic32, so best to maintain good include practices. #include "common/atomic.h" http://gerrit.cloudera.org:8080/#/c/15244/4/be/src/exec/parquet/parquet-column-readers.h@584 PS4, Line 584: ((parquet_column_reader_debug_count.Add(1) % 2) == 1 && num_tuples >= 128) This switched from a post-increment to a pre-increment, so we should actually change it to == 0 to preserve the "every other" behaviour. http://gerrit.cloudera.org:8080/#/c/15244/4/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/15244/4/be/src/runtime/krpc-data-stream-sender.cc@165 PS4, Line 165: bool IsOutboundBatchInFlight(OutboundRowBatch* outbound_batch); Could we use ANNOTATE_BENIGN_RACE on the variable instead? Or is the concern that that would hide real races? What about ANNOTATE_IGNORE_READS_BEGIN/ANNOTATE_IGNORE_READS_END around this one access http://gerrit.cloudera.org:8080/#/c/15244/4/bin/tsan-suppressions.txt File bin/tsan-suppressions.txt: http://gerrit.cloudera.org:8080/#/c/15244/4/bin/tsan-suppressions.txt@34 PS4, Line 34: # Accesses to KuduScanNode::done_ are intentionally racey; see IMPALA-4880 and the I think we could convert this to an AtomicBool too, no? -- To view, visit http://gerrit.cloudera.org:8080/15244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01feb40417dc5ea64ccb0c1044cfc3eed8508476 Gerrit-Change-Number: 15244 Gerrit-PatchSet: 4 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 21 Feb 2020 02:11:19 +0000 Gerrit-HasComments: Yes
