Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15278 )
Change subject: IMPALA-7784: Use unescaped string in partition pruning + fix duplicatedly unescaping strings ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/15278/2/fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java File fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java: http://gerrit.cloudera.org:8080/#/c/15278/2/fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java@148 PS2, Line 148: result = LiteralExpr.createFromUnescapedStr(exprNode.string_literal.value, colType); > line too long (94 > 90) Done http://gerrit.cloudera.org:8080/#/c/15278/2/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java File fe/src/main/java/org/apache/impala/catalog/KuduColumn.java: http://gerrit.cloudera.org:8080/#/c/15278/2/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java@81 PS2, Line 81: defaultValueExpr = LiteralExpr.createFromUnescapedStr(defaultValue.toString(), defaultValueType); > line too long (105 > 90) Done http://gerrit.cloudera.org:8080/#/c/15278/2/fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java: http://gerrit.cloudera.org:8080/#/c/15278/2/fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java@240 PS2, Line 240: Lists.newArrayList(LiteralExpr.createFromUnescapedStr("11.1", ScalarType.createDecimalType(1, 0)), > line too long (106 > 90) Done http://gerrit.cloudera.org:8080/#/c/15278/2/fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java@241 PS2, Line 241: LiteralExpr.createFromUnescapedStr("11.1", ScalarType.createDecimalType(1, 0))), > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/15278/2/tests/metadata/test_recover_partitions.py File tests/metadata/test_recover_partitions.py: http://gerrit.cloudera.org:8080/#/c/15278/2/tests/metadata/test_recover_partitions.py@358 PS2, Line 358: " > flake8: E501 line too long (91 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/15278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea8070f16a74f9aeade294504f2834abb8b3b38f Gerrit-Change-Number: 15278 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 24 Feb 2020 07:02:58 +0000 Gerrit-HasComments: Yes
