Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15278 )
Change subject: IMPALA-7784: Use unescaped string in partition pruning + fix duplicatedly unescaping strings ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15278/3/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java File fe/src/main/java/org/apache/impala/analysis/StringLiteral.java: http://gerrit.cloudera.org:8080/#/c/15278/3/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java@71 PS3, Line 71: // TODO: should we consider needsUnescaping_ in hashing? > tl;dr: I think that we are ok I know that HashMap<Expr> is avoided for exactly this reason. The expression substitution maps are implemented using linear search over arrays of exprs. -- To view, visit http://gerrit.cloudera.org:8080/15278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea8070f16a74f9aeade294504f2834abb8b3b38f Gerrit-Change-Number: 15278 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 24 Feb 2020 17:42:29 +0000 Gerrit-HasComments: Yes
