David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15219 )
Change subject: IMPALA-9384: Improve Impala shell usability by automatically enable live_progress in the interactive mode ...................................................................... Patch Set 1: > Patch Set 1: > > (8 comments) > > This looks like a good change, thanks. > I have a few nits and questions. I think there may be an issue with the fundamental approach here. In shell/options_parser.py, we have this code: https://github.com/apache/impala/blob/master/shell/option_parser.py#L235 parser.add_option("--live_progress", dest="live_progress", action="store_true", help="Print a query progress every 1s while the query is running.") This implies that the default setting for live_progress is False, and we need a special flag to enable it. I would start by changing this flag to --disable_live_progress (don't get me started on underscores vs hyphens for command line options) with action="store_false", and see where that gets you. -- To view, visit http://gerrit.cloudera.org:8080/15219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3765b775f663fa227e59728acffe4d5ea9a5e2d3 Gerrit-Change-Number: 15219 Gerrit-PatchSet: 1 Gerrit-Owner: Alice Fan <fan...@gmail.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Feb 2020 19:51:36 +0000 Gerrit-HasComments: No
