Alice Fan has posted comments on this change. ( http://gerrit.cloudera.org:8080/15219 )
Change subject: IMPALA-9384: Improve Impala shell usability by automatically enable live_progress in the interactive mode ...................................................................... Patch Set 1: Thanks David for your input. I would like to summarize the two possible options here: Option 1: current patch 1 + modification for --disable_live_progress Won’t set live_progress = true in impala_shell_config_default.py In impala_shell.py, we set live_progress to True when users neither set it in configuration file nor in command line AND it is in the interactive mode. Option 2: set live_progress to TRUE in impala_shell_config_default.py set live_progress to true in impala_shell_config_default.py Impala_shell implicitly disables live_progress when the non-interactive mode is detected even user set it to true in config file or/and command line Remove the check and throw FatalShellException for the case of detecting live_progress is true in non-interactive mode because of (2) Either choosing option 1 or 2, we can add “--disable_live_progress” This allows users to explicitly disable live_progress by command line when they are in interactive mode. To me, I think option 2 looks more straightforward. That is - in the non-interactive mode, live_progress will always be false no matter if a user tries to set it to true in config file and/or command line. Impala_shell will implicitly set it to false when detecting it is in non-interactive mode. As for interactive mode, by default live_progress is set to True, a user has options to set it to false in either command line or config file. David and Andrew, please let me know if you agree with option 2? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/15219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3765b775f663fa227e59728acffe4d5ea9a5e2d3 Gerrit-Change-Number: 15219 Gerrit-PatchSet: 1 Gerrit-Owner: Alice Fan <[email protected]> Gerrit-Reviewer: Alice Fan <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 28 Feb 2020 23:17:48 +0000 Gerrit-HasComments: No
