Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15250 )
Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key ...................................................................... Patch Set 10: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/15250/10/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: http://gerrit.cloudera.org:8080/#/c/15250/10/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@294 PS10, Line 294: cardinality_ < 0 || cardinality_ > 1 nit: cardinality_ != 0 could be simpler to understand http://gerrit.cloudera.org:8080/#/c/15250/10/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@386 PS10, Line 386: // The set of primary key column index which are in equality predicates and : // pushed down to Kudu. : Set<Integer> primaryKeyColsInEqualPred = new HashSet<>(); We could also add that these are equa to const predicates, e.g. the variable could be primaryKeyColsInEqualToConstPred -- To view, visit http://gerrit.cloudera.org:8080/15250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4631cd4d1a528a1152b5cdcb268426f2ba1a0c08 Gerrit-Change-Number: 15250 Gerrit-PatchSet: 10 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2020 12:31:24 +0000 Gerrit-HasComments: Yes
