Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15250 )
Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key ...................................................................... Patch Set 10: The code change looks good. Can you add planner test cases for these edge cases: * Multiple conflicting equality predicates on the kudu table -> EmptySetNode * Multiple redundant equality predicates on the kudu table -> they get deduplicated * An "is not distinct from" predicate, just to confirm that the optimisation also works for that case (I think it gets converted to = in the expr rewrites) * Redundant = and "is not distinct from" predicates, like my earlier query, to make sure they get deduplicated. I'm paranoid about test coverage for planner code like this because there are so many edge cases to cover. -- To view, visit http://gerrit.cloudera.org:8080/15250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4631cd4d1a528a1152b5cdcb268426f2ba1a0c08 Gerrit-Change-Number: 15250 Gerrit-PatchSet: 10 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2020 16:31:29 +0000 Gerrit-HasComments: No
