Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15291 )
Change subject: IMPALA-9414: Support the 'Expect: 100-continue' http header ...................................................................... Patch Set 1: > Which version should I be reviewing - this one or > https://gerrit.cloudera.org/#/c/15284/ > ? Sorry for the confusion. My preference is for us to commit the other version. After submitting it, I found out that 'six' isn't available in the system python on our Jenkins machines, so after some discussion with David I put this together as a possible option for how to accomplish the same goal without needing to package 'six' with the shell. Since we went ahead and packaged six anyways in https://gerrit.cloudera.org/#/c/15293/ the workaround is no longer needed. Its still possible though that reviewers may prefer this version of the patch. It has the advantage of not needing us to copy any source code from thrift into our repo (though the code being copied in the other version, THttpClient.py, hasn't had a commit in upstream thrift in ~2 years). On the other hand, I suspect we'll want to make further changes to how the thrift code works (eg. fixing the issue that prevents client_connect_timeout from working for the hs2-http protocol), and those changes may not be amenable to this approach, so we may end up having to copy the code over eventually either way. -- To view, visit http://gerrit.cloudera.org:8080/15291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4be7f6ac9235f25746bd4d255bbee9115f73f426 Gerrit-Change-Number: 15291 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2020 21:02:39 +0000 Gerrit-HasComments: No
