David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15284 )
Change subject: IMPALA-9414 (part 2): Support the 'Expect: 100-continue' http header ...................................................................... Patch Set 4: > Patch Set 4: > > (3 comments) That makes sense. Using exceptions.py is standard practice, but usually a package/s modules are contained within a namespace -- e.g., an example of a canonically well-designed package is the requests library. https://github.com/psf/requests/blob/master/requests/exceptions.py But all the code imports from requests.exceptions, so there's no collision with built-ins. The impala-shell makes packages available by hacking the system python path, which puts everything in a common global namespace. Argh. shell_exceptions seems like a good compromise. -- To view, visit http://gerrit.cloudera.org:8080/15284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4153968551acd58b25c7923c2ebf75ee29a7e76b Gerrit-Change-Number: 15284 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Fri, 28 Feb 2020 17:29:43 +0000 Gerrit-HasComments: No
