Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15244 )
Change subject: IMPALA-5904: (part 2) Fix more TSAN bugs ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15244/4/bin/tsan-suppressions.txt File bin/tsan-suppressions.txt: http://gerrit.cloudera.org:8080/#/c/15244/4/bin/tsan-suppressions.txt@34 PS4, Line 34: # Accesses to KuduScanNode::done_ are intentionally racey; see IMPALA-4880 and the > I think the argument about optimistic checking also works for atomic. I thi Made it an AtomicBool. I agree that making this an AtomicBool probably won't hurt performance much. One thing I will point out is that the AtomicBool is read across scan threads, multiple times per RowBatch, inside the KuduScanNode::ProcessScanToken function (which is done outside of the 'lock_'). I ran './bin/single_node_perf_run.py --table_formats kudu --workloads tpch' just to be sure, and saw no significant perf difference. -- To view, visit http://gerrit.cloudera.org:8080/15244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01feb40417dc5ea64ccb0c1044cfc3eed8508476 Gerrit-Change-Number: 15244 Gerrit-PatchSet: 4 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 28 Feb 2020 20:45:47 +0000 Gerrit-HasComments: Yes
