Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15288 )
Change subject: IMPALA-6360: Don't show full query statement on Impala webUI by default ...................................................................... Patch Set 5: (2 comments) Thank you for the update, just a two small nits, then LGTM. http://gerrit.cloudera.org:8080/#/c/15288/5/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/15288/5/be/src/service/impala-http-handler.cc@371 PS5, Line 371: /*if the statement is longer than the allowed query_stmt_size then this will cut it and : put "..." in the end. : */ I believe the bellow code part is descriptive enough and documents itself, therefore this comment can be removed. http://gerrit.cloudera.org:8080/#/c/15288/5/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/15288/5/tests/webserver/test_web_pages.py@421 PS5, Line 421: to a 'lorem ipsum' nit: I think there is no need to share this information, this part could be removed -- To view, visit http://gerrit.cloudera.org:8080/15288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7109a0be5d1022b4f8d6e72441cf5dc1dc42605 Gerrit-Change-Number: 15288 Gerrit-PatchSet: 5 Gerrit-Owner: Adam Tamas <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2020 11:47:18 +0000 Gerrit-HasComments: Yes
