Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15288 )
Change subject: IMPALA-6360: Don't show full query statement on Impala webUI by default ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Thanks for the updates. Just found one more nit, other than that LGTM! http://gerrit.cloudera.org:8080/#/c/15288/6/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/15288/6/tests/webserver/test_web_pages.py@423 PS6, Line 423: """ nit: This should be in the same line as the string, also the second line should start 3 characters earlier. Some words might also fit in the first line till col 90. -- To view, visit http://gerrit.cloudera.org:8080/15288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7109a0be5d1022b4f8d6e72441cf5dc1dc42605 Gerrit-Change-Number: 15288 Gerrit-PatchSet: 6 Gerrit-Owner: Adam Tamas <[email protected]> Gerrit-Reviewer: Adam Tamas <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2020 13:40:11 +0000 Gerrit-HasComments: Yes
