Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY ...................................................................... Patch Set 3: Code-Review+1 (1 comment) I just have one nit. Let me give a +1 now and once you covered that I can +2 http://gerrit.cloudera.org:8080/#/c/15332/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15332/3//COMMIT_MSG@12 PS3, Line 12: Added an extra AnalyzesOk into ‘AnalyzeKuduDDLTest()’ -> : ‘testDDlsOnKuduTable()’ in AnalyzeKuduDDLTest.java where the RANGE() and : HASH() pair is swapped. nit: no need to mention the each line of test change in the commit message. A single sentence without this level of technical details is fine. Like "Added and extra analyzer test to cover the case when RANGE() is before HASH() for Kudu tables." -- To view, visit http://gerrit.cloudera.org:8080/15332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c Gerrit-Change-Number: 15332 Gerrit-PatchSet: 3 Gerrit-Owner: Adam Tamas <[email protected]> Gerrit-Reviewer: Adam Tamas <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2020 09:47:36 +0000 Gerrit-HasComments: Yes
