Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15332/3/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/15332/3/fe/src/main/cup/sql-parser.cup@1601 PS3, Line 1601: followed by The comment should be also updated. http://gerrit.cloudera.org:8080/#/c/15332/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java: http://gerrit.cloudera.org:8080/#/c/15332/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@124 PS3, Line 124: A Can you add another test with range partitions first + multiple levels of hash partitions? The test at line 132 is an example for that syntax. -- To view, visit http://gerrit.cloudera.org:8080/15332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c Gerrit-Change-Number: 15332 Gerrit-PatchSet: 3 Gerrit-Owner: Adam Tamas <[email protected]> Gerrit-Reviewer: Adam Tamas <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2020 11:50:32 +0000 Gerrit-HasComments: Yes
