Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15104 )
Change subject: IMPALA-9228: ORC scanner reads rows into scratch batch ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/15104/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15104/5//COMMIT_MSG@20 PS5, Line 20: Note, > typo: testing Done http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/hdfs-columnar-scanner-ir.cc File be/src/exec/hdfs-columnar-scanner-ir.cc: http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/hdfs-columnar-scanner-ir.cc@23 PS5, Line 23: scratch_batch_ > nit: the != nullptr in written out in most of Impala Done http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/hdfs-orc-scanner.cc@702 PS5, Line 702: > nit: the != nullptr in written out in most of Impala Done http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/orc-column-readers.cc File be/src/exec/orc-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/orc-column-readers.cc@264 PS5, Line 264: >col_id_path_map_[ > Can you mention it in the commit message that no scratch batch is used if t I've already added a note about this to the commit msg. -- To view, visit http://gerrit.cloudera.org:8080/15104 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56db0325dee283d73742ebbae412d19693fac0ca Gerrit-Change-Number: 15104 Gerrit-PatchSet: 9 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2020 10:01:28 +0000 Gerrit-HasComments: Yes
