Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15104 )
Change subject: IMPALA-9228: ORC scanner reads rows into scratch batch ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/hdfs-scanner.h@a566 PS5, Line 566: : : : : > nit: maybe these could be moved together to public. Done http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/orc-column-readers.h File be/src/exec/orc-column-readers.h: http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/orc-column-readers.h@188 PS5, Line 188: Status ReadValue(int row_idx, Tuple* tuple, MemPool* pool) final WARN_UNUSED_RESULT; > Since ReadValue() is public I think you don't need the friend declarations Friend declarations are still needed for accessing 'derived->batch_' from OrcPrimitiveColumnReader::ReadValueBatch() http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/orc-column-readers.cc File be/src/exec/orc-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/orc-column-readers.cc@221 PS5, Line 221: ErrorMsg msg(errorCode, scanner_->filename(), orc_column_id_); : return scanner_- > nit: fits single line again Done -- To view, visit http://gerrit.cloudera.org:8080/15104 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56db0325dee283d73742ebbae412d19693fac0ca Gerrit-Change-Number: 15104 Gerrit-PatchSet: 7 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 02 Mar 2020 13:14:45 +0000 Gerrit-HasComments: Yes