Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15350 )
Change subject: IMPALA-6506: Codegen in ORC scanner for primitives and struct ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15350/1/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/15350/1/be/src/exec/hdfs-scan-node-base.cc@437 PS1, Line 437: case THdfsFileFormat::PARQUET: : case THdfsFileFormat::ORC: : status = HdfsColumnarScanner::Codegen(this, state, &fn); > It would be nice to check what happens if there are Parquet and ORC partiti Did check it manually and this runs without any error scanning partitions well for both formats. Added a comment about this to the commit msg. -- To view, visit http://gerrit.cloudera.org:8080/15350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2352d0c8fc75ff722e931bc8c866b3e43d3636f4 Gerrit-Change-Number: 15350 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 04 Mar 2020 12:05:42 +0000 Gerrit-HasComments: Yes
