Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15350 )
Change subject: IMPALA-6506: Codegen in ORC scanner for primitives and struct ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15350/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15350/2//COMMIT_MSG@16 PS2, Line 16: ill codegend but the codegend function : isn't used I would prefer to avoid this "regression without gain" by checking whether there are collections before codegen, but I don't have a "one liner" to do this at hand. At least a Jira could be created for using scratch batches or disabling codegen in that case. -- To view, visit http://gerrit.cloudera.org:8080/15350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2352d0c8fc75ff722e931bc8c866b3e43d3636f4 Gerrit-Change-Number: 15350 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 04 Mar 2020 14:40:01 +0000 Gerrit-HasComments: Yes
