Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15281 )
Change subject: IMPALA-4080 [part 3]: Moved codegen code for TupleRowComparator into a Config object ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Left a comment, but LGTM. http://gerrit.cloudera.org:8080/#/c/15281/5/be/src/util/tuple-row-compare.h File be/src/util/tuple-row-compare.h: http://gerrit.cloudera.org:8080/#/c/15281/5/be/src/util/tuple-row-compare.h@74 PS5, Line 74: TSortingOrder::type sorting_order_; nit: you could add a comment here, something like "Indicates the ordering used to instantiate the comparator." And maybe: "Only used with SORT BY queries". -- To view, visit http://gerrit.cloudera.org:8080/15281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I265604ecbae2c80ff59e697fddfeea4976b25cd9 Gerrit-Change-Number: 15281 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 05 Mar 2020 12:28:55 +0000 Gerrit-HasComments: Yes
