Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/15281 )
Change subject: IMPALA-4080 [part 3]: Moved codegen code for TupleRowComparator
into a Config object
......................................................................
IMPALA-4080 [part 3]: Moved codegen code for TupleRowComparator into a
Config object
This introduces a new class called TupleRowComparatorConfig that houses
the fragment level parameters needed to create a TupleRowComparator
object. It also codegens the TupleRowComparator::Compare() method that
is shared by all instances of TupleRowComparator objects created using
this config. Also, moved the related code to initiate codegen on this
class for the exchange, sort, partial sort and top-n nodes from their
exec nodes to their plan nodes.
Lastly, this also moved the code responsible for codegening
TopNNode::InsertBatch() from its exec node to its plan node.
Testing:
TODO: Sucessfully run exhaustive tests. Need to re-run after resolving
rebase conflicts.
Manually verified that codegen works for all modified exec nodes.
Change-Id: I265604ecbae2c80ff59e697fddfeea4976b25cd9
Reviewed-on: http://gerrit.cloudera.org:8080/15281
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M be/src/exec/exchange-node.cc
M be/src/exec/exchange-node.h
M be/src/exec/partial-sort-node.cc
M be/src/exec/partial-sort-node.h
M be/src/exec/sort-node.cc
M be/src/exec/sort-node.h
M be/src/exec/topn-node.cc
M be/src/exec/topn-node.h
M be/src/runtime/data-stream-test.cc
M be/src/runtime/sorter.cc
M be/src/runtime/sorter.h
M be/src/util/tuple-row-compare-test.cc
M be/src/util/tuple-row-compare.cc
M be/src/util/tuple-row-compare.h
14 files changed, 232 insertions(+), 203 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I265604ecbae2c80ff59e697fddfeea4976b25cd9
Gerrit-Change-Number: 15281
Gerrit-PatchSet: 8
Gerrit-Owner: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Norbert Luksa <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
