Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14705 )
Change subject: IMPALA-8800: Added support of Kudu DATE type to Impala ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/14705/13/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: http://gerrit.cloudera.org:8080/#/c/14705/13/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@387 PS13, Line 387: create table > Can you also add tests where we insert to / select from such a table? Did you address this? http://gerrit.cloudera.org:8080/#/c/14705/13/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@391 PS13, Line 391: 1970-01-01 > The Unix epoch is a quite unfortunate test value in my opinion, as both dat Did you address this? -- To view, visit http://gerrit.cloudera.org:8080/14705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91656749a58ac769b54c2a63bdd4f85c89520b32 Gerrit-Change-Number: 14705 Gerrit-PatchSet: 13 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2020 16:29:21 +0000 Gerrit-HasComments: Yes
