Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14705 )
Change subject: IMPALA-8800: Added support of Kudu DATE type to Impala ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/14705/13/be/src/exec/kudu-util.cc File be/src/exec/kudu-util.cc: http://gerrit.cloudera.org:8080/#/c/14705/13/be/src/exec/kudu-util.cc@133 PS13, Line 133: // If the value was invalid the slot should've been null. > What slot and why is it relevant here? This line is copied from line 121 http://gerrit.cloudera.org:8080/#/c/14705/13/be/src/exec/kudu-util.cc@135 PS13, Line 135: Invalid DateValue" > Any chance to output the value for troubleshooting? I was told that invalid value would not be printed http://gerrit.cloudera.org:8080/#/c/14705/13/be/src/exec/kudu-util.cc@135 PS13, Line 135: Invalid DateValue" > We generally do not return values in error messages to avoid leaking sensit This function is similar to the function in line 120. That function do not provide column name, so this does not do it too -- To view, visit http://gerrit.cloudera.org:8080/14705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91656749a58ac769b54c2a63bdd4f85c89520b32 Gerrit-Change-Number: 14705 Gerrit-PatchSet: 15 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2020 01:15:39 +0000 Gerrit-HasComments: Yes
