Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15411 )
Change subject: IMPALA-6267: MT scanners check filters per split ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/15411/5/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/15411/5/be/src/exec/hdfs-scan-node-base.cc@709 PS5, Line 709: !SkipIfRangePassesFilters > nit: For me it's hard to read the code with this function name. I refactored it a little bit so that StartNextScanRange() calls PartitionPassesFilters() directly and the helper function does the cleanup book-keeping. I think that makes the control flow in that loop a little clearer. http://gerrit.cloudera.org:8080/#/c/15411/5/tests/query_test/test_runtime_filters.py File tests/query_test/test_runtime_filters.py: http://gerrit.cloudera.org:8080/#/c/15411/5/tests/query_test/test_runtime_filters.py@101 PS5, Line 101: self.client.set_configuration(new_vector.get_value('exec_option')) > Can we move it out from the loop? Done http://gerrit.cloudera.org:8080/#/c/15411/5/tests/query_test/test_runtime_filters.py@107 PS5, Line 107: print self.client.get_runtime_profile(handle) > This printout seems like a leftover from debugging. Done -- To view, visit http://gerrit.cloudera.org:8080/15411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic40eb4cb2419393e6f7cd7bd019add9224946c4d Gerrit-Change-Number: 15411 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 13 Mar 2020 23:20:03 +0000 Gerrit-HasComments: Yes
