Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15411 )
Change subject: IMPALA-6267: MT scanners check filters per split ...................................................................... IMPALA-6267: MT scanners check filters per split Refactor the code for checking each scan range against filters so that it can be shared between the MT and non-MT scan node implementations. Move it into StartNextScanRange(), which has the advantage that we can skip issuing then cancelling the I/O for the range. Testing: Added a regression test for the code path that failed for multithreaded scans before this fix. Looped the test for a couple of hours to flush out flakiness. Fix some runtime filter tests where the mt_dop from the dimensions was not applied. Fix test_wait_time_cancellation() to work with mt_dop > 0, where filters are waited for in Open() instead of GetNext(), which means that the query does not get into the RUNNING state while waiting for filters. Instead use the profile to detect that execution started. Ran core tests. Change-Id: Ic40eb4cb2419393e6f7cd7bd019add9224946c4d Reviewed-on: http://gerrit.cloudera.org:8080/15411 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/hdfs-scan-node-base.cc M be/src/exec/hdfs-scan-node-base.h M be/src/exec/hdfs-scan-node-mt.cc M be/src/exec/hdfs-scan-node.cc M tests/query_test/test_runtime_filters.py 5 files changed, 84 insertions(+), 28 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic40eb4cb2419393e6f7cd7bd019add9224946c4d Gerrit-Change-Number: 15411 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
