Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15462 )
Change subject: IMPALA-9183: Convert certain disjunctive predicates to conjunctive normal form ...................................................................... Patch Set 1: (11 comments) http://gerrit.cloudera.org:8080/#/c/15462/1/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/15462/1/common/thrift/ImpalaInternalService.thrift@413 PS1, Line 413: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15462/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/15462/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@486 PS1, Line 486: rules.add(new ConvertToCNFRule(queryCtx.getClient_request().getQuery_options().getMax_cnf_exprs(), line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/15462/1/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java File fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java: http://gerrit.cloudera.org:8080/#/c/15462/1/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@121 PS1, Line 121: Expr lhs1 = (CompoundPredicate) CompoundPredicate.createDisjunctivePredicate(disjuncts); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/15462/1/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@125 PS1, Line 125: Expr rhs1 = (CompoundPredicate) CompoundPredicate.createDisjunctivePredicate(disjuncts); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/15462/1/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@126 PS1, Line 126: Predicate newPredicate = (CompoundPredicate) CompoundPredicate.createConjunction(lhs1, rhs1); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/15462/1/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@136 PS1, Line 136: Expr lhs1 = (CompoundPredicate) CompoundPredicate.createDisjunctivePredicate(disjuncts); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/15462/1/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@140 PS1, Line 140: Expr rhs1 = (CompoundPredicate) CompoundPredicate.createDisjunctivePredicate(disjuncts); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/15462/1/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@141 PS1, Line 141: Predicate newPredicate = (CompoundPredicate) CompoundPredicate.createConjunction(lhs1, rhs1); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/15462/1/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@165 PS1, Line 165: Predicate newPredicate = (CompoundPredicate) CompoundPredicate.createConjunction(lhs1, rhs1); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/15462/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java: http://gerrit.cloudera.org:8080/#/c/15462/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@817 PS1, Line 817: RewritesOk("(int_col > 10 AND float_col < 5.0) OR (int_col < 20 AND float_col > 15.0)", rule, line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/15462/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@819 PS1, Line 819: "AND int_col > 10 OR float_col > 15.0 AND int_col > 10 OR int_col < 20"); line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/15462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a03cd7239333aaf375416ef5f2b7608fcd4a072 Gerrit-Change-Number: 15462 Gerrit-PatchSet: 1 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 17 Mar 2020 15:37:29 +0000 Gerrit-HasComments: Yes
