Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15462 )

Change subject: IMPALA-9183: Convert disjunctive predicates to conjunctive 
normal form
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/15462/2/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java
File fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java:

http://gerrit.cloudera.org:8080/#/c/15462/2/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@122
PS2, Line 122:                 (CompoundPredicate) 
CompoundPredicate.createDisjunctivePredicate(disjuncts);
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/15462/2/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@127
PS2, Line 127:                 (CompoundPredicate) 
CompoundPredicate.createDisjunctivePredicate(disjuncts);
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/15462/2/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@140
PS2, Line 140:                 (CompoundPredicate) 
CompoundPredicate.createDisjunctivePredicate(disjuncts);
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/15462/2/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@145
PS2, Line 145:                 (CompoundPredicate) 
CompoundPredicate.createDisjunctivePredicate(disjuncts);
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/15462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a03cd7239333aaf375416ef5f2b7608fcd4a072
Gerrit-Change-Number: 15462
Gerrit-PatchSet: 2
Gerrit-Owner: Aman Sinha <amsi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Mar 2020 16:26:08 +0000
Gerrit-HasComments: Yes

Reply via email to