Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15475 )
Change subject: IMPALA-9492: Fix test_unescaped_string_partition failing on S3 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15475/3/tests/metadata/test_recover_partitions.py File tests/metadata/test_recover_partitions.py: http://gerrit.cloudera.org:8080/#/c/15475/3/tests/metadata/test_recover_partitions.py@370 PS3, Line 370: parts = [ : single_quote, : double_quote, : back_slash + single_quote, : back_slash + double_quote, : back_slash + back_slash + single_quote, : back_slash + back_slash + double_quote : ] Now that there is no mapping writing the original string here seems more readable to me. -- To view, visit http://gerrit.cloudera.org:8080/15475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63d149c9bdec52c2e1c0b25c8c3f0448cf7bdadb Gerrit-Change-Number: 15475 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 19 Mar 2020 16:21:50 +0000 Gerrit-HasComments: Yes
