Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15475 )
Change subject: IMPALA-9492: Fix test_unescaped_string_partition failing on S3 ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15475/3/tests/metadata/test_recover_partitions.py File tests/metadata/test_recover_partitions.py: http://gerrit.cloudera.org:8080/#/c/15475/3/tests/metadata/test_recover_partitions.py@370 PS3, Line 370: # partition value string using the %xx escape. e.g. p=' will become p=%27. : hex_part = urllib.parse.quote(parts[i]) : self.create_fs_partition(tbl_location, "p=%s" % hex_part, "file_%d" % i, str(i)) : : self.execute_query_expect_success( : self.client, "ALTER TABLE %s RECOVER PARTITIONS" % fq_tbl_name) : result = self.execute_query_expect_success( : > Now that there is no mapping writing the original string here seems more re Done -- To view, visit http://gerrit.cloudera.org:8080/15475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63d149c9bdec52c2e1c0b25c8c3f0448cf7bdadb Gerrit-Change-Number: 15475 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 19 Mar 2020 17:39:05 +0000 Gerrit-HasComments: Yes
