Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15462 )
Change subject: IMPALA-9183: Convert disjunctive predicates to conjunctive normal form ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Only one minor thing I noticed on my second pass. http://gerrit.cloudera.org:8080/#/c/15462/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15462/4//COMMIT_MSG@22 PS4, Line 22: enables or disables the entire rewrite. This is False by default until we Do we have a follow-on JIRA to change the default? http://gerrit.cloudera.org:8080/#/c/15462/4/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/15462/4/be/src/service/query-options.cc@924 PS4, Line 924: query_options->__set_max_cnf_exprs(atoi(value.c_str())); It'd be good to use the stricter parsing that some other options use, e.g. FETCH_ROWS_TIMEOUT_MS which uses StringToInt(). -- To view, visit http://gerrit.cloudera.org:8080/15462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a03cd7239333aaf375416ef5f2b7608fcd4a072 Gerrit-Change-Number: 15462 Gerrit-PatchSet: 4 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 19 Mar 2020 23:53:16 +0000 Gerrit-HasComments: Yes
