Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15529 )
Change subject: IMPALA-8980: Remove functional*.alltypesinsert from EE tests ...................................................................... Patch Set 1: (3 comments) Thanks for taking care about this! http://gerrit.cloudera.org:8080/#/c/15529/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15529/1//COMMIT_MSG@11 PS1, Line 11: -Swapped out the Reset table and Drop partition SETUP tags to Truncate table QUERY statement. Do we still use SETUP anywhere in the tests? If not, then it would be great to remove it from https://github.com/apache/impala/blob/master/tests/common/impala_test_suite.py#L770 http://gerrit.cloudera.org:8080/#/c/15529/1//COMMIT_MSG@12 PS1, Line 12: -Deleted a test query in ‘insert.test’. The test incorrectly tried to clear out a table which was not working, and should not work either. nit: please wrap commit message lines at 72 chars + I added more comments to the deleted test http://gerrit.cloudera.org:8080/#/c/15529/1/testdata/workloads/functional-query/queries/QueryTest/insert.test File testdata/workloads/functional-query/queries/QueryTest/insert.test: http://gerrit.cloudera.org:8080/#/c/15529/1/testdata/workloads/functional-query/queries/QueryTest/insert.test@a675 PS1, Line 675: : : : : : : : : : : : : : : : Instead of deleting we could also for test the current behavior. Note that it is actually not self evident what to do in this case (INSERT OVERWRITE with dynamic partitioning). Hive doesn't delete all partitions, while Spark does it by default (it has an option to decide: spark.sql.sources.partitionOverwriteMode). -- To view, visit http://gerrit.cloudera.org:8080/15529 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I257e936868917a2fcc6c030f6c855b247e8a0eea Gerrit-Change-Number: 15529 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Tamas <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 23 Mar 2020 20:39:51 +0000 Gerrit-HasComments: Yes
