Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15529 )
Change subject: IMPALA-8980: Remove functional*.alltypesinsert from EE tests ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15529/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15529/1//COMMIT_MSG@11 PS1, Line 11: -Swapped out the Reset table and Drop partition SETUP tags to Truncate table QUERY statement. > There are 2 more tests where we use SETUP. Should I swap them out too and r Yes, I would like to remove SETUP completely - the advantage of using normal query blocks is that they: - are executed in the order you see in the .test file, while SETUP always runs before the QUERY - use normal Impala SQL syntax while SETUP adds new commands SETUP seems like a fossil from the early days of Impala when it couldn't write tables so it had to rely on Hive. http://gerrit.cloudera.org:8080/#/c/15529/1/testdata/workloads/functional-query/queries/QueryTest/insert.test File testdata/workloads/functional-query/queries/QueryTest/insert.test: http://gerrit.cloudera.org:8080/#/c/15529/1/testdata/workloads/functional-query/queries/QueryTest/insert.test@a675 PS1, Line 675: : : : : : : : : : : : : : : : > This test case was added when IMPALA-89 got resolved which implies that it I agree, this test was "buggy" and passed for the wrong reason, but I would prefer to fix it to test how Impala works instead of deleting it. -- To view, visit http://gerrit.cloudera.org:8080/15529 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I257e936868917a2fcc6c030f6c855b247e8a0eea Gerrit-Change-Number: 15529 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Tamas <[email protected]> Gerrit-Reviewer: Adam Tamas <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 24 Mar 2020 13:13:00 +0000 Gerrit-HasComments: Yes
