Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/15564 )
Change subject: IMPALA-9555: [Hive3] Fix test failure introduced by HIVE-22589 ...................................................................... Patch Set 1: > I have a basic design question: couldn't we set hive.avro.proleptic.gregorian > to true during dataload instead of changing the tests? As other > formats use gregorian as far as I know, this seems a better to me, > at least to test interop with Impala. Parquet and Orc fileformats have the same issues with the DATE type as Avro. They may also use Gregorian or Julian Calendar depending on which version of Hive they were written by. The failing test is failing only for Avro because: 1. the test is skipped for ORC (not sure if this is on purpose or by accident). 2. the Parquet test table has been written by Impala (instead of Hive) during the data load. We also have tests for ORC and Parquet to demonstrate the issues related to the Julian vs Gregorian Calendars, but they use pre-created ORC/Parquet files (written by Hive2) and are not affected by HIVE-22589. I don't see much value in forcing Gregorian Calendar for writing Avro tables. The rewritten tests show the default behavior users can expect: pre -1582-10-12 DATEs are incorrect, but everything after that is working fine. -- To view, visit http://gerrit.cloudera.org:8080/15564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51dd933867ea7877235e7f6e1f2b56711dca107e Gerrit-Change-Number: 15564 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Thu, 26 Mar 2020 20:38:30 +0000 Gerrit-HasComments: No
