Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15564 )
Change subject: IMPALA-9555: [Hive3] Fix test failure introduced by HIVE-22589 ...................................................................... Patch Set 1: Code-Review+2 >. the test is skipped for ORC (not sure if this is on purpose or by accident). My guess is that updating this test was forgotten in the quite recent https://gerrit.cloudera.org/#/c/14982/ I think that in the ideal case we should test both: Julian to test that invalid dates are handled properly (this probably has to be file format specific, as error messages are different) and Gregorian to have a more extended suite of tests that can run on more file formats. The change itself looks good to me, but I am worried about the back and forth changes in Hive. -- To view, visit http://gerrit.cloudera.org:8080/15564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51dd933867ea7877235e7f6e1f2b56711dca107e Gerrit-Change-Number: 15564 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Thu, 26 Mar 2020 22:28:59 +0000 Gerrit-HasComments: No
