Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15623 )
Change subject: Add CentOS 8.1 support to bootstrap_system.sh ...................................................................... Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/15623/5/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/15623/5/bin/bootstrap_system.sh@266 PS5, Line 266: sudo alternatives --add-slave python /usr/bin/python2 /usr/bin/pip pip /usr/bin/pip2 It's a little unfortunate to do this to the system, but I guess there's not a better alternative for now. It's not a big deal if it's running in a container or build worker dedicated to building impala, but would be extremely annoying for someone developing on CentOS8. I don't think there's a better way to solve it except for updating all python calls in the codebase or supporting python 3, so doesn't make sense to try to fix now. http://gerrit.cloudera.org:8080/#/c/15623/5/bin/bootstrap_system.sh@367 PS5, Line 367: redhat8 indocker sudo -u postgres PGDATA=/var/lib/pgsql/data bash -c \ Not a blocker, but it would be nice to have a way to avoid the duplication between redhat versions where the logic is identical. E.g. have a command for a range of versions like. redhat7_8 -- To view, visit http://gerrit.cloudera.org:8080/15623 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3df5d48eca7a10219264e3604a4f05f072188e6e Gerrit-Change-Number: 15623 Gerrit-PatchSet: 5 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 02 Apr 2020 17:21:16 +0000 Gerrit-HasComments: Yes
