David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15623 )
Change subject: Add CentOS 8.1 support to bootstrap_system.sh ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15623/5/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/15623/5/bin/bootstrap_system.sh@266 PS5, Line 266: sudo alternatives --add-slave python /usr/bin/python2 /usr/bin/pip pip /usr/bin/pip2 > It's a little unfortunate to do this to the system, but I guess there's not I need to look at the other reviews, but there are very few places where we actually call the system python (rather than impala-python), or the system pip. Could we just go through and find those spots, and replace the calls with python2/pip2 explicitly if we detect that python2 is not the default? -- To view, visit http://gerrit.cloudera.org:8080/15623 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3df5d48eca7a10219264e3604a4f05f072188e6e Gerrit-Change-Number: 15623 Gerrit-PatchSet: 5 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 02 Apr 2020 20:42:30 +0000 Gerrit-HasComments: Yes
