Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 )
Change subject: Use Python from the toolchain for Impala ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/15624/6/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/15624/6/infra/python/bootstrap_virtualenv.py@50 PS6, Line 50: # Ensure the ssl modules are loaded correctly. : import ssl : from httplib import HTTPConnection : from urllib2 import HTTPSHandle > Tim, are these items still needed/useful here with tmp.py duplicating it? I think this was for my debugging only, so we can remove it. http://gerrit.cloudera.org:8080/#/c/15624/6/infra/python/bootstrap_virtualenv.py@209 PS6, Line 209: # This is the only time when $IMPALA_HOME/bin needs to be on PYTHONPATH, This feels like a bit of a hack, but I think we can live with it. http://gerrit.cloudera.org:8080/#/c/15624/6/infra/python/tmp.py File infra/python/tmp.py: PS6: I think we can remove this, this was just for debugging issues I was having on CentOS 6 -- To view, visit http://gerrit.cloudera.org:8080/15624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7b40cef89cfb3b467b61b2d54a94e708642882b Gerrit-Change-Number: 15624 Gerrit-PatchSet: 6 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 02 Apr 2020 17:56:06 +0000 Gerrit-HasComments: Yes
