Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 )
Change subject: Use Python from the toolchain for Impala ...................................................................... Patch Set 7: (1 comment) > Patch Set 6: > > (1 comment) Passed a core-mode test run on private infrastructure on CentOS 7.4 http://gerrit.cloudera.org:8080/#/c/15624/6/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/15624/6/infra/python/bootstrap_virtualenv.py@211 PS6, Line 211: sys.path.append(os.environ.get("IMPALA_HOME") + "/bin") : from bootstrap_toolchain import (ToolchainPackage) > I'm not sure there's anything to be gained by not having these at the top o I opted for the local import when the debug output from the SSL imports above made me realize that bootstrap_virtualenv.py is invoked every time a Python script with the impala_python shebang is loaded. I have not measured how much latency the import would add to it, but it seemed like a good way to avoid adding latency and increasing coupling at the same time. That said, the impact is probably not high, so I'm OK with placing the import at the top of the file, if you think it improves readability. -- To view, visit http://gerrit.cloudera.org:8080/15624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7b40cef89cfb3b467b61b2d54a94e708642882b Gerrit-Change-Number: 15624 Gerrit-PatchSet: 7 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 08 Apr 2020 15:18:28 +0000 Gerrit-HasComments: Yes
