Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 )
Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking ...................................................................... Patch Set 1: (2 comments) Thanks for your quick review, Csaba! http://gerrit.cloudera.org:8080/#/c/15654/1/fe/src/main/java/org/apache/impala/planner/JoinNode.java File fe/src/main/java/org/apache/impala/planner/JoinNode.java: http://gerrit.cloudera.org:8080/#/c/15654/1/fe/src/main/java/org/apache/impala/planner/JoinNode.java@225 PS1, Line 225: used not > rather "not used"? Yes! Done. http://gerrit.cloudera.org:8080/#/c/15654/1/fe/src/main/java/org/apache/impala/planner/JoinNode.java@240 PS1, Line 240: for (TupleId tid : tblRefIds_) { > Is it possible to move this logic to analyzer.getUnassignedConjuncts? Or t Yeah, don't want to impact other kind of PlanNodes since only the query block of joins can have multi-tuple predicates. But I agree to move these logics into Analyzer which looks more clean. -- To view, visit http://gerrit.cloudera.org:8080/15654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3 Gerrit-Change-Number: 15654 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 06 Apr 2020 12:05:13 +0000 Gerrit-HasComments: Yes
