Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 )
Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1493 PS3, Line 1493: if (node instanceof JoinNode) { > Yeah, but to add this marker, we still need to loop over all the TableRefs For adding the marker I thought you would just need to add a boolean 'isAssociatedWithMasking' to JoinNode and set it to true in the JoinNode.init() line #224. Something like: List<TupleDescriptor> tupleDescs = analyzer.materializeSlots(conjuncts_); this.isAssociatedWithMasking = tupleDescs.size() > 0 ? true : false; // <-- this is based on your clarification that other // cases will have empty list of tuple descriptors. Would that work ? If not, I am fine with deferring the optimization to the future. http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/planner/JoinNode.java File fe/src/main/java/org/apache/impala/planner/JoinNode.java: http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/planner/JoinNode.java@224 PS3, Line 224: for (TupleDescriptor tuple : analyzer.materializeSlots(conjuncts_)) { > analyzer.materializeSlots(conjuncts_) only returns the affected tuples. In Yeah, if you can add a Preconditions check that would be good. -- To view, visit http://gerrit.cloudera.org:8080/15654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3 Gerrit-Change-Number: 15654 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 07 Apr 2020 05:35:17 +0000 Gerrit-HasComments: Yes
