Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 )
Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 ...................................................................... Patch Set 5: (4 comments) do we need to do any perf testing, even if it is ad-hoc / sanity checks? http://gerrit.cloudera.org:8080/#/c/15642/5/LICENSE.txt File LICENSE.txt: http://gerrit.cloudera.org:8080/#/c/15642/5/LICENSE.txt@616 PS5, Line 616: sqlparse-0.1.19 version update? http://gerrit.cloudera.org:8080/#/c/15642/5/README.md File README.md: http://gerrit.cloudera.org:8080/#/c/15642/5/README.md@a75 PS5, Line 75: why remove all of this? http://gerrit.cloudera.org:8080/#/c/15642/5/infra/python/deps/requirements.txt File infra/python/deps/requirements.txt: http://gerrit.cloudera.org:8080/#/c/15642/5/infra/python/deps/requirements.txt@a60 PS5, Line 60: somewhat related question, why do we need to check in a copy of sqlparse? http://gerrit.cloudera.org:8080/#/c/15642/5/infra/python/deps/requirements.txt@a59 PS5, Line 59: : : is this no longer true? -- To view, visit http://gerrit.cloudera.org:8080/15642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001 Gerrit-Change-Number: 15642 Gerrit-PatchSet: 5 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 07 Apr 2020 13:51:40 +0000 Gerrit-HasComments: Yes
